crypto: add sanity checking of TLS x509 credentials
commit9a2fd4347c40321f5cbb4ab4220e759fcbf87d03
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 13 Apr 2015 13:01:39 +0000 (13 14:01 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 15 Sep 2015 14:05:09 +0000 (15 15:05 +0100)
tree25449f7fa2cd329313c25e69b5ec5fb740d91c45
parent85bcbc789eb65b54548a507b747ffffe6175b404
crypto: add sanity checking of TLS x509 credentials

If the administrator incorrectly sets up their x509 certificates,
the errors seen at runtime during connection attempts are very
obscure and difficult to diagnose. This has been a particular
problem for people using openssl to generate their certificates
instead of the gnutls certtool, because the openssl tools don't
turn on the various x509 extensions that gnutls expects to be
present by default.

This change thus adds support in the TLS credentials object to
sanity check the certificates when QEMU first loads them. This
gives the administrator immediate feedback for the majority of
common configuration mistakes, reducing the pain involved in
setting up TLS. The code is derived from equivalent code that
has been part of libvirt's TLS support and has been seen to be
valuable in assisting admins.

It is possible to disable the sanity checking, however, via
the new 'sanity-check' property on the tls-creds object type,
with a value of 'no'.

Unit tests are included in this change to verify the correctness
of the sanity checking code in all the key scenarios it is
intended to cope with. As part of the test suite, the pkix_asn1_tab.c
from gnutls is imported. This file is intentionally copied from the
(long since obsolete) gnutls 1.6.3 source tree, since that version
was still under GPLv2+, rather than the GPLv3+ of gnutls >= 2.0.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
configure
crypto/tlscredsx509.c
include/crypto/tlscredsx509.h
tests/.gitignore
tests/Makefile
tests/crypto-tls-x509-helpers.c [new file with mode: 0644]
tests/crypto-tls-x509-helpers.h [new file with mode: 0644]
tests/pkix_asn1_tab.c [new file with mode: 0644]
tests/test-crypto-tlscredsx509.c [new file with mode: 0644]
trace-events