monitor: Remove "x-oob", offer capability "oob" unconditionally
commit8258292e18c39480b64eba9f3551ab772ce29b5d
authorPeter Xu <peterx@redhat.com>
Tue, 9 Oct 2018 06:27:15 +0000 (9 14:27 +0800)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 12 Dec 2018 09:28:27 +0000 (12 10:28 +0100)
treec2e842bf2e48ff34e2b8b3fdd681ab48aeff1666
parent9ab84470ffc2781df3acd4607bc6d2ae64d6d7e3
monitor: Remove "x-oob", offer capability "oob" unconditionally

Out-of-band command execution was introduced in commit cf869d53172.
Unfortunately, we ran into a regression, and had to turn it into an
experimental option for 2.12 (commit be933ffc23).

  http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html

The regression has since been fixed (commit 951702f39c7 "monitor: bind
dispatch bh to iohandler context").  A thorough re-review of OOB
commands led to a few more issues, which have also been addressed.

This patch partly reverts be933ffc23 (monitor: new parameter "x-oob"),
and makes QMP monitors again offer capability "oob" whenever they can
provide it, i.e. when the monitor's character device is capable of
running in an I/O thread.

Some trivial touch-up in the test code is required to make sure qmp-test
won't break.

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20181009062718.1914-4-peterx@redhat.com>
[Conflict with "monitor: check if chardev can switch gcontext for OOB"
resolved, commit message updated]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
include/monitor/monitor.h
monitor.c
tests/libqtest.c
tests/qmp-test.c
vl.c