scsi: reject configurations with logical block size > physical block size
commit3da023b5827543ee4c022986ea2ad9d1274410b2
authorMark Kanda <mark.kanda@oracle.com>
Mon, 16 Oct 2017 20:17:04 +0000 (16 15:17 -0500)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 18 Oct 2017 09:56:14 +0000 (18 11:56 +0200)
tree828b494c9e3076eb907c48a5fdd97571468aa017
parentf7b879e072ae6839b1b1d1312f48fa7f256397e2
scsi: reject configurations with logical block size > physical block size

Logical block size of a SCSI disk should never be larger than
physical block size. From an ATA/SCSI perspective, it makes no sense
to have the logical block size greater than the physical block size,
and it cannot even be effectively expressed in the command set. The
whole point of adding the physical block size to the ATA/SCSI command
set was to communicate a desire for a larger block size (than logical),
while maintaining backwards compatibility with legacy 512 byte block
size.

When setting logical_block_size > physical_block_size, QEMU cannot express
it in READ CAPACITY(16) output, and all it can do is set the physical
block exponent to 0 (i.e. logical_block_size == physical_block_size).
Reporting the error properly, however, is better.

Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Message-Id: <1508185024-5840-1-git-send-email-mark.kanda@oracle.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/scsi/scsi-disk.c