| commit | ffa207d08253ffffb3993a1dbe09e40af4fc91f1 | |
| author | David Hildenbrand <david@redhat.com> | |
| Mon, 22 Jul 2019 13:41:03 +0000 (22 15:41 +0200) | ||
| committer | Michael S. Tsirkin <mst@redhat.com> | |
| Thu, 25 Jul 2019 11:57:49 +0000 (25 07:57 -0400) | ||
| tree | 0ff22de456194441ad60bba6de278b59b6538c02 | treesnapshot (tar.gz zip) |
| parent | ee4b0c8686f781987879508d7c6dd605b5435bac | commitdiff |
virtio-balloon: Fix wrong sign extension of PFNs
If we directly cast from int to uint64_t, we will first sign-extend to
an int64_t, which is wrong. We actually want to treat the PFNs like
unsigned values.
As far as I can see, this dates back to the initial virtio-balloon
commit, but wasn't triggered as fairly big guests would be required.
Cc: qemu-stable@nongnu.org
Reported-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190722134108.22151-2-david@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
If we directly cast from int to uint64_t, we will first sign-extend to
an int64_t, which is wrong. We actually want to treat the PFNs like
unsigned values.
As far as I can see, this dates back to the initial virtio-balloon
commit, but wasn't triggered as fairly big guests would be required.
Cc: qemu-stable@nongnu.org
Reported-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190722134108.22151-2-david@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
| hw/virtio/virtio-balloon.c | diffblobblamehistory |