pc-bios/s390-ccw: Use reset_psw pointer instead of hard-coded null pointer
commitff77712a8a2e15e5901fad35b9a6bb65974b2e4a
authorThomas Huth <thuth@redhat.com>
Fri, 23 Apr 2021 08:30:51 +0000 (23 10:30 +0200)
committerThomas Huth <thuth@redhat.com>
Sun, 9 May 2021 16:14:31 +0000 (9 18:14 +0200)
tree354bc09d5e16179ee9b672a79b0e333a31cef4b7
parentd08a64940452060ab7ad5eb49cd5801131c2b9ec
pc-bios/s390-ccw: Use reset_psw pointer instead of hard-coded null pointer

When compiling the s390-ccw bios with clang, it emits a warning like this:

 pc-bios/s390-ccw/jump2ipl.c:86:9: warning: indirection of non-volatile null
  pointer will be deleted, not trap [-Wnull-dereference]
     if (*((uint64_t *)0) & RESET_PSW_MASK) {
         ^~~~~~~~~~~~~~~~
 pc-bios/s390-ccw/jump2ipl.c:86:9: note: consider using __builtin_trap() or
  qualifying pointer with 'volatile'

We could add a "volatile" here to shut it up, but on the other hand,
we also have a pointer variable called "reset_psw" in this file already
that points to the PSW at address 0, so we can simply use that pointer
variable instead.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210423142440.582188-1-thuth@redhat.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
pc-bios/s390-ccw/jump2ipl.c