virtiofsd: probe unshare(CLONE_FS) and print an error
commitfd9279ec9985d9c8a0b533eff24839f93695b0f4
authorStefan Hajnoczi <stefanha@redhat.com>
Mon, 27 Jul 2020 19:02:23 +0000 (27 20:02 +0100)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Fri, 28 Aug 2020 12:34:52 +0000 (28 13:34 +0100)
treeb210ce2d6976249b5eeaa6d4f4698f7b8711628d
parent1c7cb1f52e2577e190c09c9a14e6b6f56f4a3ec3
virtiofsd: probe unshare(CLONE_FS) and print an error

An assertion failure is raised during request processing if
unshare(CLONE_FS) fails. Implement a probe at startup so the problem can
be detected right away.

Unfortunately Docker/Moby does not include unshare in the seccomp.json
list unless CAP_SYS_ADMIN is given. Other seccomp.json lists always
include unshare (e.g. podman is unaffected):
https://raw.githubusercontent.com/seccomp/containers-golang/master/seccomp.json

Use "docker run --security-opt seccomp=path/to/seccomp.json ..." if the
default seccomp.json is missing unshare.

Cc: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20200727190223.422280-4-stefanha@redhat.com>
Reviewed-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
tools/virtiofsd/fuse_virtio.c