hw/usb: hcd-xhci-pci: Fix spec violation of IP flag for MSI/MSI-X
commitfc967aad408eb4777b099d17ada1f39be5f6fd2e
authorRuimei Yan <ruimei.yan@windriver.com>
Fri, 21 May 2021 02:42:24 +0000 (21 10:42 +0800)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 28 May 2021 07:10:20 +0000 (28 09:10 +0200)
tree45b56123354608ea6b9fa00361eb8686e4e37656
parent3c6151cd11ae7e4a7dae10f8c17ab1fe2f0a73bf
hw/usb: hcd-xhci-pci: Fix spec violation of IP flag for MSI/MSI-X

Per xHCI spec v1.2 chapter 4.17.5 page 296:

  If MSI or MSI-X interrupts are enabled, Interrupt Pending (IP)
  shall be cleared automatically when the PCI dword write generated
  by the interrupt assertion is complete.

Currently QEMU does not clear the IP flag in the MSI / MSI-X mode.
This causes subsequent spurious interrupt to be delivered to guests.
To solve this, we change the xhci intr_raise() hook routine to have
a bool return value that is passed to its caller (the xhci core),
with true indicating that IP should be self-cleared.

Fixes: 62c6ae04cf43 ("xhci: Initial xHCI implementation")
Fixes: 4c47f800631a ("xhci: add msix support")
Signed-off-by: Ruimei Yan <ruimei.yan@windriver.com>
[bmeng: move IP clear codes from xhci pci to xhci core]
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Message-Id: <20210521024224.2277634-2-bmeng.cn@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw/usb/hcd-xhci-pci.c
hw/usb/hcd-xhci-sysbus.c
hw/usb/hcd-xhci.c
hw/usb/hcd-xhci.h