| commit | fc0932fdcfc3e5cafa3641e361b681c07f639812 | |
| author | Fam Zheng <famz@redhat.com> | |
| Tue, 2 May 2017 16:35:53 +0000 (3 00:35 +0800) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Thu, 11 May 2017 09:15:32 +0000 (11 11:15 +0200) | ||
| tree | 8ac8a503750e097b472915e499ae6318500a7ccf | treesnapshot (tar.gz zip) |
| parent | 9c77fec2d366a2fc7848e9b58b82504365a664ae | commitdiff |
block: Reuse bs as backing hd for drive-backup sync=none
Opening the backing image for the second time is bad, especially here
when it is also in use as the active image as the source. The
drive-backup job itself doesn't read from target->backing for COW,
instead it gets data from the write notifier, so it's not a big problem.
However, exporting the target to NBD etc. won't work, because of the
likely stale metadata cache.
Use BDRV_O_NO_BACKING in this case and manually set up the backing
BdrvChild.
Cc: qemu-stable@nongnu.org
Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Opening the backing image for the second time is bad, especially here
when it is also in use as the active image as the source. The
drive-backup job itself doesn't read from target->backing for COW,
instead it gets data from the write notifier, so it's not a big problem.
However, exporting the target to NBD etc. won't work, because of the
likely stale metadata cache.
Use BDRV_O_NO_BACKING in this case and manually set up the backing
BdrvChild.
Cc: qemu-stable@nongnu.org
Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| blockdev.c | diffblobblamehistory |