Stop including qemu-common.h in memory.h
commitfba0a593b2809ecdda68650952cf3d3332ac1990
authorPeter Maydell <peter.maydell@linaro.org>
Fri, 3 Jul 2015 14:18:24 +0000 (3 15:18 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 6 Jul 2015 12:59:09 +0000 (6 14:59 +0200)
treea5810e02760af31710c62e4d67d10239c60159a4
parentde7ea885c5394c1fba7443cbf33bd2745d32e6c2
Stop including qemu-common.h in memory.h

Including qemu-common.h from other header files is generally a bad
idea, because it means it's very easy to end up with a circular
dependency. For instance, if we wanted to include memory.h from
qom/cpu.h we'd end up with this loop:
 memory.h -> qemu-common.h -> cpu.h -> cpu-qom.h -> qom/cpu.h -> memory.h

Remove the include from memory.h. This requires us to fix up a few
other files which were inadvertently getting declarations indirectly
through memory.h.

The biggest change is splitting the fprintf_function typedef out
into its own header so other headers can get at it without having
to include qemu-common.h.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <1435933104-15216-1-git-send-email-peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
include/exec/cpu-common.h
include/exec/memory.h
include/hw/arm/arm.h
include/qemu-common.h
include/qemu/fprintf-fn.h [new file with mode: 0644]
target-s390x/mmu_helper.c