rtl8139: Fix receive buffer overflow check
commitfabdcd3392f16fc666b1d04fc1bbe5f1dbbf10a4
authorVladislav Yasevich <vyasevic@redhat.com>
Tue, 1 Sep 2015 15:26:45 +0000 (1 11:26 -0400)
committerStefan Hajnoczi <stefanha@redhat.com>
Wed, 2 Sep 2015 12:42:31 +0000 (2 13:42 +0100)
tree77b53dd72e56d9df2a23be9b76144683a332a26a
parent26c0114d3f69c3accaf83d56ff1d850bd0213b58
rtl8139: Fix receive buffer overflow check

rtl8139_do_receive() tries to check for the overflow condition
by making sure that packet_size + 8 does not exceed the
available buffer space.  The issue here is that RxBuffAddr,
used to calculate available buffer space, is aligned to a
a 4 byte boundry after every update.  So it is possible that
every packet ends up being slightly padded when written
to the receive buffer.  This padding is not taken into
account when checking for overflow and we may end up missing
the overflow condition can causing buffer overwrite.

This patch takes alignment into consideration when
checking for overflow condition.

Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
Reviewed-by: Jason Wang <jasowang@redhat.com>
Message-id: 1441121206-6997-2-git-send-email-vyasevic@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/net/rtl8139.c