| commit | fa110c6a9e6c0ae0ce2d4bcf5771cdb8c3e53a7e | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Fri, 27 Sep 2019 13:46:29 +0000 (27 15:46 +0200) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Sat, 28 Sep 2019 15:17:19 +0000 (28 17:17 +0200) | ||
| tree | 6f9a4338cdd579a82e4144a0b04eabce8b7ae5e3 | treesnapshot (tar.gz zip) |
| parent | 77daece3d95dc7edaa5982fbbfd7afe3bc4121ac | commitdiff |
qapi: Move context-sensitive checking to the proper place
When we introduced the QAPISchema intermediate representation (commit
ac88219a6c7), we took a shortcut: we left check_exprs() & friends
alone instead of moving semantic checks into the
QAPISchemaFOO.check(). The .check() assert check_exprs() did its job.
Time to finish the conversion job. Move exactly the context-sensitive
checks to the .check(). They replace assertions there. Context-free
checks stay put.
Fixes the misleading optional tag error demonstrated by test
flat-union-optional-discriminator.
A few other error message improve.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190927134639.4284-17-armbru@redhat.com>
When we introduced the QAPISchema intermediate representation (commit
ac88219a6c7), we took a shortcut: we left check_exprs() & friends
alone instead of moving semantic checks into the
QAPISchemaFOO.check(). The .check() assert check_exprs() did its job.
Time to finish the conversion job. Move exactly the context-sensitive
checks to the .check(). They replace assertions there. Context-free
checks stay put.
Fixes the misleading optional tag error demonstrated by test
flat-union-optional-discriminator.
A few other error message improve.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190927134639.4284-17-armbru@redhat.com>
40 files changed: