| commit | f88676c149d3c7cde2710c137aa5ef31e7f92eb4 | |
| author | Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | |
| Fri, 27 Sep 2019 12:23:50 +0000 (27 15:23 +0300) | ||
| committer | John Snow <jsnow@redhat.com> | |
| Thu, 17 Oct 2019 21:02:32 +0000 (17 17:02 -0400) | ||
| tree | 571c7320deee46d80811cd84b552740fc48fba1e | treesnapshot (tar.gz zip) |
| parent | 5752f89a788537cccc7a8e05904fb1b4ddf5eb43 | commitdiff |
block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps
Firstly, no reason to optimize failure path. Then, function name is
ambiguous: it checks for readonly and similar things, but someone may
think that it will ignore normal bitmaps which was just unchanged, and
this is in bad relation with the fact that we should drop IN_USE flag
for unchanged bitmaps in the image.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-id: 20190927122355.7344-5-vsementsov@virtuozzo.com
Signed-off-by: John Snow <jsnow@redhat.com>
Firstly, no reason to optimize failure path. Then, function name is
ambiguous: it checks for readonly and similar things, but someone may
think that it will ignore normal bitmaps which was just unchanged, and
this is in bad relation with the fact that we should drop IN_USE flag
for unchanged bitmaps in the image.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-id: 20190927122355.7344-5-vsementsov@virtuozzo.com
Signed-off-by: John Snow <jsnow@redhat.com>
| block/dirty-bitmap.c | diffblobblamehistory | |
| block/qcow2-bitmap.c | diffblobblamehistory | |
| include/block/dirty-bitmap.h | diffblobblamehistory |