virtio-serial-bus: Unset hotplug handler when unrealize
commitf811f97040a48358b456b46ecbc9167f0131034f
authorLadi Prosek <lprosek@redhat.com>
Tue, 30 May 2017 08:59:43 +0000 (30 10:59 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Fri, 2 Jun 2017 15:57:16 +0000 (2 18:57 +0300)
treec123b0d74f9531f7a061e6a17dd001f843f15746
parentd47a851caeda96d5979bf48d4bae6a87784ad91d
virtio-serial-bus: Unset hotplug handler when unrealize

Virtio serial device controls the lifetime of virtio-serial-bus and
virtio-serial-bus links back to the device via its hotplug-handler
property. This extra ref-count prevents the device from getting
finalized, leaving the VirtIODevice memory listener registered and
leading to use-after-free later on.

This patch addresses the same issue as Fam Zheng's
"virtio-scsi: Unset hotplug handler when unrealize"
only for a different virtio device.

Cc: qemu-stable@nongnu.org
Signed-off-by: Ladi Prosek <lprosek@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
hw/char/virtio-serial-bus.c