| commit | f67432a2019caf05b57a146bf45c1024a5cb608e | |
| author | John Snow <jsnow@redhat.com> | |
| Thu, 30 Aug 2018 01:57:26 +0000 (29 21:57 -0400) | ||
| committer | Max Reitz <mreitz@redhat.com> | |
| Fri, 31 Aug 2018 14:28:33 +0000 (31 16:28 +0200) | ||
| tree | 8fac71ab094f84d2fe97941428fe69f3a3195844 | treesnapshot (tar.gz zip) |
| parent | 7b43db3cd08f722d743c443ac3713195875d0301 | commitdiff |
jobs: change start callback to run callback
Presently we codify the entry point for a job as the "start" callback,
but a more apt name would be "run" to clarify the idea that when this
function returns we consider the job to have "finished," except for
any cleanup which occurs in separate callbacks later.
As part of this clarification, change the signature to include an error
object and a return code. The error ptr is not yet used, and the return
code while captured, will be overwritten by actions in the job_completed
function.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20180830015734.19765-2-jsnow@redhat.com
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Presently we codify the entry point for a job as the "start" callback,
but a more apt name would be "run" to clarify the idea that when this
function returns we consider the job to have "finished," except for
any cleanup which occurs in separate callbacks later.
As part of this clarification, change the signature to include an error
object and a return code. The error ptr is not yet used, and the return
code while captured, will be overwritten by actions in the job_completed
function.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20180830015734.19765-2-jsnow@redhat.com
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>