fuzz: Expect the cmdline in a freeable GString
commitf5ec79f5e0a3a307fc2a11b3ba8066a2d0a90233
authorAlexander Bulekov <alxndr@bu.edu>
Tue, 14 Jul 2020 17:46:16 +0000 (14 13:46 -0400)
committerThomas Huth <thuth@redhat.com>
Fri, 17 Jul 2020 08:44:23 +0000 (17 10:44 +0200)
tree5b16a8ec3a9689c0d67be2f600a2a4ad61a579e0
parent15c51f724ec61ab6a6910c41113d6d07164b6ca4
fuzz: Expect the cmdline in a freeable GString

In the initial FuzzTarget, get_init_cmdline returned a char *. With this
API, we had no guarantee about where the string came from. For example,
i440fx-qtest-reboot-fuzz simply returned a pointer to a string literal,
while the QOS-based targets build the arguments out in a GString an
return the gchar *str pointer. Since we did not try to free the cmdline,
we have a leak for any targets that do not simply return string
literals. Clean up this mess by forcing fuzz-targets to return
a GString, that we can free.

Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Message-Id: <20200714174616.20709-1-alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/qtest/fuzz/fuzz.c
tests/qtest/fuzz/fuzz.h
tests/qtest/fuzz/i440fx_fuzz.c
tests/qtest/fuzz/qos_fuzz.c