hw/arm/digic: Mark device with user_creatable = false
commitf58f25599b72c7479e6a1ff67c7f671823aa14da
authorThomas Huth <thuth@redhat.com>
Mon, 4 Sep 2017 14:21:55 +0000 (4 15:21 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 4 Sep 2017 16:13:53 +0000 (4 17:13 +0100)
tree55d744dcda4ab44455e37f3f88d8c898f3f376b1
parent469f3da42ef4af347fa7831e1cc0bd35d17f5b83
hw/arm/digic: Mark device with user_creatable = false

QEMU currently shows some unexpected behavior when the user trys to
do a "device_add digic" on an unrelated ARM machine like integratorcp
in "-nographic" mode (the device_add command does not immediately
return to the monitor prompt), and trying to "device_del" the device
later results in a "qemu/qdev-monitor.c:872:qdev_unplug: assertion
failed: (hotplug_ctrl)" error condition.
Looking at the realize function of the device, it uses serial_hds
directly and this means that the device can not be added a second
time, so let's simply mark it with "user_creatable = false" now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/arm/digic.c