block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK
commitf2208fdc5ba2f4d0cbc023e2530b5e3e110d71c2
authorAlberto Garcia <berto@igalia.com>
Mon, 14 Oct 2019 08:15:45 +0000 (14 11:15 +0300)
committerKevin Wolf <kwolf@redhat.com>
Mon, 14 Oct 2019 15:12:48 +0000 (14 17:12 +0200)
treeb182d432c52849da44e25597a2ffbfbd374b4908
parente4ec5ad464e48ab8d978b4dd8aacd05c1c4a87cc
block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

The BDRV_REQ_NO_FALLBACK flag means that an operation should only be
performed if it can be offloaded or otherwise performed efficiently.

However a misaligned write request requires a RMW so we should return
an error and let the caller decide how to proceed.

This hits an assertion since commit c8bb23cbdb if the required
alignment is larger than the cluster size:

qemu-img create -f qcow2 -o cluster_size=2k img.qcow2 4G
qemu-io -c "open -o driver=qcow2,file.align=4k blkdebug::img.qcow2" \
        -c 'write 0 512'
qemu-io: block/io.c:1127: bdrv_driver_pwritev: Assertion `!(flags & BDRV_REQ_NO_FALLBACK)' failed.
Aborted

The reason is that when writing to an unallocated cluster we try to
skip the copy-on-write part and zeroize it using BDRV_REQ_NO_FALLBACK
instead, resulting in a write request that is too small (2KB cluster
size vs 4KB required alignment).

Signed-off-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/io.c
tests/qemu-iotests/268 [new file with mode: 0755]
tests/qemu-iotests/268.out [new file with mode: 0644]
tests/qemu-iotests/group