| commit | f14bc040b073257f0eb8200042634c0d15f59ea7 | |
| author | John Snow <jsnow@redhat.com> | |
| Fri, 24 Jul 2020 05:22:55 +0000 (24 01:22 -0400) | ||
| committer | John Snow <jsnow@redhat.com> | |
| Thu, 1 Oct 2020 17:04:16 +0000 (1 13:04 -0400) | ||
| tree | a9005107b978c83f19dc9d21b918e52048535f93 | treesnapshot (tar.gz zip) |
| parent | 98d98912238d9f4f4c41bda0a3d944d0cff934ce | commitdiff |
ide: don't tamper with the device register
In real ISA operation, register writes go out to an entire bus channel
and all listening devices receive the write. The devices do not toggle
the DEV bit based on their own configuration, nor does the HBA
intermediate or tamper with that value.
The reality of the matter is that DEV0/DEV1 accordingly will react to
command register writes based on whether or not the device was selected.
This does not fix a known bug, but it makes the code slightly simpler
and more obvious.
Signed-off-by: John Snow <jsnow@redhat.com>
In real ISA operation, register writes go out to an entire bus channel
and all listening devices receive the write. The devices do not toggle
the DEV bit based on their own configuration, nor does the HBA
intermediate or tamper with that value.
The reality of the matter is that DEV0/DEV1 accordingly will react to
command register writes based on whether or not the device was selected.
This does not fix a known bug, but it makes the code slightly simpler
and more obvious.
Signed-off-by: John Snow <jsnow@redhat.com>
| hw/ide/core.c | diffblobblamehistory |