hw/9pfs: Remove O_NOATIME flag from 9pfs open() calls in readonly mode
commiteed968607d656a218712df47a5e0432c21fd6994
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 16 Jan 2012 18:11:40 +0000 (16 18:11 +0000)
committerAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Mon, 30 Jan 2012 05:24:17 +0000 (30 10:54 +0530)
treee23d3348aa434d16be2f1931b8ca68e5baf9bb2d
parent68e59e14605f9e6390d8d975f9ab919be9176bc2
hw/9pfs: Remove O_NOATIME flag from 9pfs open() calls in readonly mode

When 2c74c2cb4bedddbfa67628fbd5f9273b4e0e9903 added support for
the 'readonly' flag against 9p filesystems, it also made QEMU
add the O_NOATIME flag as a side-effect.

The O_NOATIME flag, however, may only be set by the file owner,
or a user with CAP_FOWNER capability.  QEMU cannot assume that
this is the case for filesytems exported to QEMU.

eg, run QEMU as non-root, and attempt to pass the host OS
filesystem through to the guest OS with readonly enable.
The result is that the guest OS cannot open any files at
all.

If O_NOATIME is really required, it should be optionally
enabled via a separate QEMU command line flag.

 * hw/9pfs/virtio-9p.c: Remove O_NOATIME

Acked-by: M. Mohan Kumar <mohan@in.ibm.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
hw/9pfs/virtio-9p.c