| commit | eebe0b7905642a986cbce7406d6ab7bf78f3e210 | |
| author | Gerd Hoffmann <kraxel@redhat.com> | |
| Tue, 24 Jan 2017 09:00:28 +0000 (24 10:00 +0100) | ||
| committer | Gerd Hoffmann <kraxel@redhat.com> | |
| Tue, 31 Jan 2017 07:52:52 +0000 (31 08:52 +0100) | ||
| tree | 8daffe2c375b3f097a0c1314a02a15092f5e5d42 | treesnapshot (tar.gz zip) |
| parent | 51e0b654539d587f09fc23074d1ae2a9c7747b06 | commitdiff |
vnc: fix overflow in vnc_update_stats
Commit "bea60dd ui/vnc: fix potential memory corruption issues" is
incomplete. vnc_update_stats must calculate width and height the same
way vnc_refresh_server_surface does it, to make sure we don't use width
and height values larger than the qemu vnc server can handle.
Commit "e22492d ui/vnc: disable adaptive update calculations if not
needed" masks the issue in the default configuration. It triggers only
in case the "lossy" option is set to "on" (default is "off").
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 1485248428-575-1-git-send-email-kraxel@redhat.com
Commit "bea60dd ui/vnc: fix potential memory corruption issues" is
incomplete. vnc_update_stats must calculate width and height the same
way vnc_refresh_server_surface does it, to make sure we don't use width
and height values larger than the qemu vnc server can handle.
Commit "e22492d ui/vnc: disable adaptive update calculations if not
needed" masks the issue in the default configuration. It triggers only
in case the "lossy" option is set to "on" (default is "off").
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 1485248428-575-1-git-send-email-kraxel@redhat.com
| ui/vnc.c | diffblobblamehistory |