vfio: don't ignore return value of migrate_add_blocker
commited92369a5725ae42c28128778f154798f1464c26
authorJens Freimann <jfreimann@redhat.com>
Mon, 18 Nov 2019 17:41:48 +0000 (18 10:41 -0700)
committerAlex Williamson <alex.williamson@redhat.com>
Mon, 18 Nov 2019 17:41:48 +0000 (18 10:41 -0700)
tree778e9042c97fad225905473cc23ac29f072f51fa
parent1335d64323be87ee14c766c59fabfb7e9acd7af7
vfio: don't ignore return value of migrate_add_blocker

When an error occurs in migrate_add_blocker() it sets a
negative return value and uses error pointer we pass in.
Instead of just looking at the error pointer check for a negative return
value and avoid a coverity error because the return value is
set but never used. This fixes CID 1407219.

Reported-by: Coverity (CID 1407219)
Fixes: f045a0104c8c ("vfio: unplug failover primary device before migration")
Signed-off-by: Jens Freimann <jfreimann@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
hw/vfio/pci.c