monitor: Make current monitor a per-coroutine property
commite69ee454b5f9dff3af48bcfc3d9691b3edb02fe2
authorKevin Wolf <kwolf@redhat.com>
Mon, 5 Oct 2020 15:58:48 +0000 (5 17:58 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 9 Oct 2020 05:08:19 +0000 (9 07:08 +0200)
tree50d13aedafd82f3efdb50a50be8bae13aa5d8379
parent41725fa7eda1d97576fc8c79b58d04a61629f40e
monitor: Make current monitor a per-coroutine property

This way, a monitor command handler will still be able to access the
current monitor, but when it yields, all other code code will correctly
get NULL from monitor_cur().

This uses a hash table to map the coroutine pointer to the current
monitor of that coroutine.  Outside of coroutine context, we associate
the current monitor with the leader coroutine of the current thread.

Approaches to implement some form of coroutine local storage directly in
the coroutine core code have been considered and discarded because they
didn't end up being much more generic than the hash table and their
performance impact on coroutines not using coroutine local storage was
unclear. As the block layer uses a coroutine per I/O request, this is a
fast path and we have to be careful. It's safest to just stay out of
this path with code only used by the monitor.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20201005155855.256490-8-kwolf@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
include/monitor/monitor.h
monitor/hmp.c
monitor/monitor.c
qapi/qmp-dispatch.c
stubs/monitor-core.c