nbd: generalize usage of nbd_read
commite6798f06a67a25def45a6636259de38cc38f1414
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Mon, 28 Jan 2019 16:58:30 +0000 (28 19:58 +0300)
committerEric Blake <eblake@redhat.com>
Mon, 4 Feb 2019 21:11:27 +0000 (4 15:11 -0600)
treeaa6666d07f2722947fea9f44b19aa1ec9d4ca5fa
parent0ae2d54645eb2888af6dc7f701bc02ca18e4e656
nbd: generalize usage of nbd_read

We generally do very similar things around nbd_read: error_prepend
specifying what we have tried to read, and be_to_cpu conversion of
integers.

So, it seems reasonable to move common things to helper functions,
which:
1. simplify code a bit
2. generalize nbd_read error descriptions, all starting with
   "Failed to read"
3. make it more difficult to forget to convert things from BE

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190128165830.165170-1-vsementsov@virtuozzo.com>
[eblake: rename macro to DEF_NBD_READ_N and formatting tweaks;
checkpatch has false positive complaint]
Signed-off-by: Eric Blake <eblake@redhat.com>
block/nbd-client.c
include/block/nbd.h
nbd/client.c
nbd/common.c
nbd/server.c