virtio: optimize virtio_access_is_big_endian() for little-endian targets
commite5157e313cd9c2d57f28873318d0bb29c77a9b1a
authorGreg Kurz <gkurz@linux.vnet.ibm.com>
Fri, 5 Feb 2016 10:46:18 +0000 (5 11:46 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 16 Feb 2016 10:05:18 +0000 (16 12:05 +0200)
tree573ed52460db661a7448c5160e771de02b547de6
parent46f70ff148ae01e2dc96e64c393e295a0092555d
virtio: optimize virtio_access_is_big_endian() for little-endian targets

When adding cross-endian support, we introduced the TARGET_IS_BIENDIAN macro
and the virtio_access_is_big_endian() helper to have a branchless fast path
in the virtio memory accessors for targets that don't switch endian.

This was considered as a strong requirement at the time.

Now we have added a runtime check for virtio 1.0, which ruins the benefit
of the virtio_access_is_big_endian() helper for always little-endian targets.

With this patch, always little-endian targets stop checking for virtio 1.0,
since the result is little-endian in all cases.

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
include/hw/virtio/virtio-access.h