| commit | e38bc23454ef763deb4405ebdee6a1081aa00bc8 | |
| author | Peter Lieven <pl@kamp.de> | |
| Fri, 8 Dec 2017 11:51:08 +0000 (8 12:51 +0100) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Thu, 21 Dec 2017 08:30:32 +0000 (21 09:30 +0100) | ||
| tree | 415ed460eeab4a597cf4a908215ac094bddc6f83 | treesnapshot (tar.gz zip) |
| parent | aef172ffdc2f9c41d9cc043a55f1259e7c07e587 | commitdiff |
block/iscsi: only report an iSCSI Failure if we don't handle it gracefully
we currently report an "iSCSI Failure" in iscsi_co_generic_cb if the task
hasn't completed with SCSI_STATUS_GOOD. However, we expect a failure in
some cases and handle it gracefully. This is the case for misaligned UNMAPs
and WRITESAME10/16 calls without UNMAP. In this case a failure in the
logs can be quite misleading.
While we are at it improve the logging to reveal which operation failed
at what LBA.
Signed-off-by: Peter Lieven <pl@kamp.de>
Message-Id: <1512733868-9009-3-git-send-email-pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
we currently report an "iSCSI Failure" in iscsi_co_generic_cb if the task
hasn't completed with SCSI_STATUS_GOOD. However, we expect a failure in
some cases and handle it gracefully. This is the case for misaligned UNMAPs
and WRITESAME10/16 calls without UNMAP. In this case a failure in the
logs can be quite misleading.
While we are at it improve the logging to reveal which operation failed
at what LBA.
Signed-off-by: Peter Lieven <pl@kamp.de>
Message-Id: <1512733868-9009-3-git-send-email-pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| block/iscsi.c | diffblobblamehistory |