| commit | e2328a11bda7a4d087200c524333adafb8beb7d7 | |
| author | Paolo Bonzini <pbonzini@redhat.com> | |
| Mon, 9 Dec 2019 13:30:08 +0000 (9 14:30 +0100) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Wed, 18 Dec 2019 01:34:13 +0000 (18 02:34 +0100) | ||
| tree | 1a671e664c6c9f6cdc5aa0fa27b24fe2e76585f3 | treesnapshot (tar.gz zip) |
| parent | 97d8381543647887bc2997ecfeccc67831e47fdc | commitdiff |
vga: cleanup mapping of VRAM for non-PCI VGA
vga_init_vbe is now used only from ISA VGA cards. Since the alias is
not needed anymore, remove it (effectively reverting commit 8294a64d7f,
"vga: fix vram double-mapping with -vga std and -M pc-0.12", 2012-05-29)
and the now unused vbe_mapped field of VGACommonState. The function now
consists of a single memory_region_add_subregion call, so we can inline
it; this avoids incorrect usage from PCI cards.
Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Based-on: <05af415a-5058-98b4-4a12-9d093a30b1e3@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
vga_init_vbe is now used only from ISA VGA cards. Since the alias is
not needed anymore, remove it (effectively reverting commit 8294a64d7f,
"vga: fix vram double-mapping with -vga std and -M pc-0.12", 2012-05-29)
and the now unused vbe_mapped field of VGACommonState. The function now
consists of a single memory_region_add_subregion call, so we can inline
it; this avoids incorrect usage from PCI cards.
Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Based-on: <05af415a-5058-98b4-4a12-9d093a30b1e3@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/display/vga-isa-mm.c | diffblobblamehistory | |
| hw/display/vga-isa.c | diffblobblamehistory | |
| hw/display/vga.c | diffblobblamehistory | |
| hw/display/vga_int.h | diffblobblamehistory |