| commit | e1f81c1478398713f14c1b6ba011d4bb841dea27 | |
| author | Klaus Jensen <k.jensen@samsung.com> | |
| Tue, 8 Dec 2020 07:43:04 +0000 (8 08:43 +0100) | ||
| committer | Klaus Jensen <k.jensen@samsung.com> | |
| Mon, 8 Feb 2021 17:55:48 +0000 (8 18:55 +0100) | ||
| tree | 9eb337903977cf4993f31a6b5a90effbf0e91db3 | treesnapshot (tar.gz zip) |
| parent | 0a384f923f519b4229c07816900e87f4a28d3abb | commitdiff |
hw/block/nvme: fix bad clearing of CAP
Commit 37712e00b1f0 ("hw/block/nvme: factor out pmr setup") changed the
control flow such that the CAP register is erronously cleared after
nvme_init_pmr() has configured it. Since the entire NvmeCtrl structure
is zero-filled initially, there is no need for the explicit clearing, so
just remove it.
Fixes: 37712e00b1f0 ("hw/block/nvme: factor out pmr setup")
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
Commit 37712e00b1f0 ("hw/block/nvme: factor out pmr setup") changed the
control flow such that the CAP register is erronously cleared after
nvme_init_pmr() has configured it. Since the entire NvmeCtrl structure
is zero-filled initially, there is no need for the explicit clearing, so
just remove it.
Fixes: 37712e00b1f0 ("hw/block/nvme: factor out pmr setup")
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
| hw/block/nvme.c | diffblobblamehistory |