net: Forbid dealing with packets when VM is not running
commite1d64c084b2cc7e907b4e64026d8c8dba59116f8
authorzhanghailiang <zhang.zhanghailiang@huawei.com>
Tue, 26 Aug 2014 08:06:17 +0000 (26 16:06 +0800)
committerStefan Hajnoczi <stefanha@redhat.com>
Thu, 4 Sep 2014 13:31:54 +0000 (4 14:31 +0100)
tree6e26e084d20ad717c68ccb3ac72f0218e2cc3d6d
parent30eaca3acdf17d7bcbd1213eb149c02037edfb0b
net: Forbid dealing with packets when VM is not running

For all NICs(except virtio-net) emulated by qemu,
Such as e1000, rtl8139, pcnet and ne2k_pci,
Qemu can still receive packets when VM is not running.

If this happened in *migration's* last PAUSE VM stage, but
before the end of the migration, the new receiving packets will possibly dirty
parts of RAM which has been cached in *iovec*(will be sent asynchronously) and
dirty parts of new RAM which will be missed.
This will lead serious network fault in VM.

To avoid this, we forbid receiving packets in generic net code when
VM is not running.

Bug reproduction steps:
(1) Start a VM which configured at least one NIC
(2) In VM, open several Terminal and do *Ping IP -i 0.1*
(3) Migrate the VM repeatedly between two Hosts
And the *PING* command in VM will very likely fail with message:
'Destination HOST Unreachable', the NIC in VM will stay unavailable unless you
run 'service network restart'

Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Reviewed-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
net/net.c