hw: Replace anti-social QOM type names
commite178113ff6465b55893c2b048b0a4be82a7bbd25
authorMarkus Armbruster <armbru@redhat.com>
Thu, 4 Mar 2021 14:02:28 +0000 (4 15:02 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 19 Mar 2021 14:18:43 +0000 (19 15:18 +0100)
treedccd715a994f75ca727c2c6838cd1237bcb51e3b
parentfe9f70a1c37d2b00c41836788cf97116a99d338b
hw: Replace anti-social QOM type names

Several QOM type names contain ',':

    ARM,bitband-memory
    etraxfs,pic
    etraxfs,serial
    etraxfs,timer
    fsl,imx25
    fsl,imx31
    fsl,imx6
    fsl,imx6ul
    fsl,imx7
    grlib,ahbpnp
    grlib,apbpnp
    grlib,apbuart
    grlib,gptimer
    grlib,irqmp
    qemu,register
    SUNW,bpp
    SUNW,CS4231
    SUNW,DBRI
    SUNW,DBRI.prom
    SUNW,fdtwo
    SUNW,sx
    SUNW,tcx
    xilinx,zynq_slcr
    xlnx,zynqmp
    xlnx,zynqmp-pmu-soc
    xlnx,zynq-xadc

These are all device types.  They can't be plugged with -device /
device_add, except for xlnx,zynqmp-pmu-soc, and I doubt that one
actually works.

They *can* be used with -device / device_add to request help.
Usability is poor, though: you have to double the comma, like this:

    $ qemu-system-x86_64 -device SUNW,,fdtwo,help

Trap for the unwary.  The fact that this was broken in
device-introspect-test for more than six years until commit e27bd49876
fixed it demonstrates that "the unwary" includes seasoned developers.

One QOM type name contains ' ': "ICH9 SMB".  Because having to
remember just one way to quote would be too easy.

Rename the "SUNW,FOO types to "sun-FOO".  Summarily replace ',' and '
' by '-' in the other type names.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210304140229.575481-2-armbru@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
27 files changed:
hw/arm/xilinx_zynq.c
hw/audio/cs4231.c
hw/block/fdc.c
hw/char/etraxfs_ser.c
hw/cris/axis_dev88.c
hw/display/tcx.c
hw/intc/etraxfs_pic.c
hw/microblaze/xlnx-zynqmp-pmu.c
hw/misc/zynq_slcr.c
hw/sparc/sun4m.c
hw/timer/etraxfs_timer.c
include/hw/arm/armv7m.h
include/hw/arm/fsl-imx25.h
include/hw/arm/fsl-imx31.h
include/hw/arm/fsl-imx6.h
include/hw/arm/fsl-imx6ul.h
include/hw/arm/fsl-imx7.h
include/hw/arm/xlnx-zynqmp.h
include/hw/cris/etraxfs.h
include/hw/i386/ich9.h
include/hw/misc/grlib_ahb_apb_pnp.h
include/hw/misc/zynq-xadc.h
include/hw/register.h
include/hw/sparc/grlib.h
softmmu/vl.c
tests/vmstate-static-checker-data/dump1.json
tests/vmstate-static-checker-data/dump2.json