| commit | e0a039e50d481dce6b4ee45a29002538a258cd89 | |
| author | zhanghailiang <zhang.zhanghailiang@huawei.com> | |
| Tue, 5 Apr 2016 03:43:55 +0000 (5 11:43 +0800) | ||
| committer | Jason Wang <jasowang@redhat.com> | |
| Wed, 6 Apr 2016 01:52:07 +0000 (6 09:52 +0800) | ||
| tree | 22e254efdf47f85606f50136363636c33250bf34 | treesnapshot (tar.gz zip) |
| parent | 91731d5f6d85ca33e7c151e8feac3d5cfafec4d4 | commitdiff |
filter-buffer: fix segfault when starting qemu with status=off property
After commit 338d3f, we support 'status' property for filter object.
The segfault can be triggered by starting qemu with 'status=off' property
for filter, when the s->incoming_queue is NULL, we reference it directly
in qemu_net_queue_flush() which was called in status_changed() callback
function.
We shouldn't trigger status_changed() before the filter was initialized,
We can check the value of 'nf->netdev' to confirm if the filter is
initialized or not, so let's check its value before calling
status_changed().
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
After commit 338d3f, we support 'status' property for filter object.
The segfault can be triggered by starting qemu with 'status=off' property
for filter, when the s->incoming_queue is NULL, we reference it directly
in qemu_net_queue_flush() which was called in status_changed() callback
function.
We shouldn't trigger status_changed() before the filter was initialized,
We can check the value of 'nf->netdev' to confirm if the filter is
initialized or not, so let's check its value before calling
status_changed().
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
| net/filter.c | diffblobblamehistory |