| commit | e08a98357b5811e7933ff077f6da4b85175caf8a | |
| author | John Snow <jsnow@redhat.com> | |
| Sat, 4 Jul 2015 06:06:05 +0000 (4 02:06 -0400) | ||
| committer | John Snow <jsnow@redhat.com> | |
| Sat, 4 Jul 2015 06:06:05 +0000 (4 02:06 -0400) | ||
| tree | c810139efe4ddf237f34d9c9ac767c1fc49f1648 | treesnapshot (tar.gz zip) |
| parent | 9364384de0e3b8a5bdea67ba49bee9ea7f1b8f26 | commitdiff |
ahci: correct ncq sector count
uint16_t isn't enough to hold the real sector count, since a value of
zero implies a full 64K sectors, so we need a uint32_t here.
We *could* cheat and pretend that this value is 0-based and fit it in
a uint16_t, but I'd rather waste 2 bytes instead of a future dev's
10 minutes when they forget to +1/-1 accordingly somewhere.
See SATA 3.2, section 13.6.4.1 "READ FPDMA QUEUED".
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 1435767578-32743-9-git-send-email-jsnow@redhat.com
uint16_t isn't enough to hold the real sector count, since a value of
zero implies a full 64K sectors, so we need a uint32_t here.
We *could* cheat and pretend that this value is 0-based and fit it in
a uint16_t, but I'd rather waste 2 bytes instead of a future dev's
10 minutes when they forget to +1/-1 accordingly somewhere.
See SATA 3.2, section 13.6.4.1 "READ FPDMA QUEUED".
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 1435767578-32743-9-git-send-email-jsnow@redhat.com
| hw/ide/ahci.c | diffblobblamehistory | |
| hw/ide/ahci.h | diffblobblamehistory |