json: Fix latent parser aborts at end of input
commite06d008ac833ac220b920f4d8858e6f62f7a59f9
authorMarkus Armbruster <armbru@redhat.com>
Thu, 23 Aug 2018 16:40:11 +0000 (23 18:40 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 24 Aug 2018 18:26:37 +0000 (24 20:26 +0200)
tree8b28f96005d8129d8b8ab14882f9d0a9dfcb1670
parent2a4794ba146d6560bd77ca840ff6908f81d585f4
json: Fix latent parser aborts at end of input

json-parser.c carefully reports end of input like this:

    token = parser_context_pop_token(ctxt);
    if (token == NULL) {
        parse_error(ctxt, NULL, "premature EOI");
        goto out;
    }

Except parser_context_pop_token() can't return null, it fails its
assertion instead.  Same for parser_context_peek_token().  Broken in
commit 65c0f1e9558, and faithfully preserved in commit 95385fe9ace.
Only a latent bug, because the streamer throws away any input that
could trigger it.

Drop the assertions, so we can fix the streamer in the next commit.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180823164025.12553-45-armbru@redhat.com>
qobject/json-parser.c