| commit | df4938a6651b1f980018f9eaf86af43e6b9d7fed | |
| author | Greg Kurz <groug@kaod.org> | |
| Sun, 26 Feb 2017 22:43:00 +0000 (26 23:43 +0100) | ||
| committer | Greg Kurz <groug@kaod.org> | |
| Tue, 28 Feb 2017 10:21:15 +0000 (28 11:21 +0100) | ||
| tree | 1525239f0724b2b9ff84c84153927ef5a8f45021 | treesnapshot (tar.gz zip) |
| parent | 72f0d0bf51362011c4d841a89fb8f5cfb16e0bf3 | commitdiff |
9pfs: local: unlinkat: don't follow symlinks
The local_unlinkat() callback is vulnerable to symlink attacks because it
calls remove() which follows symbolic links in all path elements but the
rightmost one.
This patch converts local_unlinkat() to rely on opendir_nofollow() and
unlinkat() instead.
Most of the code is moved to a separate local_unlinkat_common() helper
which will be reused in a subsequent patch to fix the same issue in
local_remove().
This partly fixes CVE-2016-9602.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
The local_unlinkat() callback is vulnerable to symlink attacks because it
calls remove() which follows symbolic links in all path elements but the
rightmost one.
This patch converts local_unlinkat() to rely on opendir_nofollow() and
unlinkat() instead.
Most of the code is moved to a separate local_unlinkat_common() helper
which will be reused in a subsequent patch to fix the same issue in
local_remove().
This partly fixes CVE-2016-9602.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
| hw/9pfs/9p-local.c | diffblobblamehistory |