aio-posix: don't duplicate fd handler deletion in fdmon_io_uring_destroy()
commitde137e44f75d9868f5b548638081850f6ac771f2
authorStefan Hajnoczi <stefanha@redhat.com>
Mon, 11 May 2020 18:36:29 +0000 (11 19:36 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 18 May 2020 17:16:00 +0000 (18 18:16 +0100)
treea65668f7666bb2b8c4c25f073095dee296db862c
parent6fb5f0842aab0f744eebfabefb447b3a3a1af7cc
aio-posix: don't duplicate fd handler deletion in fdmon_io_uring_destroy()

The io_uring file descriptor monitoring implementation has an internal
list of fd handlers that are pending submission to io_uring.
fdmon_io_uring_destroy() deletes all fd handlers on the list.

Don't delete fd handlers directly in fdmon_io_uring_destroy() for two
reasons:
1. This duplicates the aio-posix.c AioHandler deletion code and could
   become outdated if the struct changes.
2. Only handlers with the FDMON_IO_URING_REMOVE flag set are safe to
   remove. If the flag is not set then something still has a pointer to
   the fd handler. Let aio-posix.c and its user worry about that. In
   practice this isn't an issue because fdmon_io_uring_destroy() is only
   called when shutting down so all users have removed their fd
   handlers, but the next patch will need this!

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Oleksandr Natalenko <oleksandr@redhat.com>
Message-id: 20200511183630.279750-2-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
util/aio-posix.c
util/fdmon-io_uring.c