| commit | dd154c4d9f48a44ad24e13f46033d0f10a05c923 | |
| author | Daniel P. Berrangé <berrange@redhat.com> | |
| Wed, 20 Feb 2019 18:22:39 +0000 (20 18:22 +0000) | ||
| committer | Daniel P. Berrangé <berrange@redhat.com> | |
| Wed, 20 Mar 2019 16:56:30 +0000 (20 16:56 +0000) | ||
| tree | 631956f639cfeb4def77abda251511f9ee5e500a | treesnapshot (tar.gz zip) |
| parent | 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2 | commitdiff |
io: fix handling of EOF / error conditions in websock GSource
We were never reporting the G_IO_HUP event when an end of file was hit
on the websocket channel.
We also didn't report G_IO_ERR when we hit a fatal error processing the
websocket protocol.
The latter in particular meant that the chardev code would not notice
when an eof/error was encountered on the websocket channel, unless the
guest OS happened to trigger a write operation.
This meant that once the first client had quit, the chardev would never
listen to accept a new client.
Fixes launchpad bug 1816819
Acked-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
We were never reporting the G_IO_HUP event when an end of file was hit
on the websocket channel.
We also didn't report G_IO_ERR when we hit a fatal error processing the
websocket protocol.
The latter in particular meant that the chardev code would not notice
when an eof/error was encountered on the websocket channel, unless the
guest OS happened to trigger a write operation.
This meant that once the first client had quit, the chardev would never
listen to accept a new client.
Fixes launchpad bug 1816819
Acked-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
| io/channel-websock.c | diffblobblamehistory |