util/qemu-sockets: fix keep_alive handling in inet_connect_saddr
commitda5e1169183ca6eb6fb470dc32ed1bfc24d1d406
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Tue, 10 Sep 2019 07:59:43 +0000 (10 10:59 +0300)
committerEric Blake <eblake@redhat.com>
Wed, 25 Sep 2019 13:15:44 +0000 (25 08:15 -0500)
treedb51ff2e33f0446f3db5758999e16f1c49477451
parent506902c6fa80210b002e30ff33794bfc718b15c6
util/qemu-sockets: fix keep_alive handling in inet_connect_saddr

In "if (saddr->keep_alive) {" we may already be on error path, with
invalid sock < 0. Fix it by returning error earlier.

Reported-by: Coverity (CID 1405300)
Fixes: aec21d31756cbd
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20190910075943.12977-1-vsementsov@virtuozzo.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
util/qemu-sockets.c