| commit | d792bc3811f22a22a46c7d9a725fd29029f54095 | |
| author | Stefan Hajnoczi <stefanha@redhat.com> | |
| Thu, 24 Aug 2017 07:22:00 +0000 (24 08:22 +0100) | ||
| committer | Stefan Hajnoczi <stefanha@redhat.com> | |
| Tue, 5 Sep 2017 09:32:06 +0000 (5 10:32 +0100) | ||
| tree | 050d6c420bae261d0909575b340dc37bf1fac2f9 | treesnapshot (tar.gz zip) |
| parent | 2b483739791b33c46e6084b51edcf62107058ae1 | commitdiff |
qemu.py: make VM() a context manager
There are a number of ways to ensure that the QEMU process is shut down
when the test ends, including atexit.register(), try: finally:, or
unittest.teardown() methods. All of these require extra code and the
programmer must remember to add vm.shutdown().
A nice solution is context managers:
with VM(binary) as vm:
...
# vm is guaranteed to be shut down here
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-id: 20170824072202.26818-2-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
There are a number of ways to ensure that the QEMU process is shut down
when the test ends, including atexit.register(), try: finally:, or
unittest.teardown() methods. All of these require extra code and the
programmer must remember to add vm.shutdown().
A nice solution is context managers:
with VM(binary) as vm:
...
# vm is guaranteed to be shut down here
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-id: 20170824072202.26818-2-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
| scripts/qemu.py | diffblobblamehistory |