| commit | d6e58090fed20e30e6966007bc4df0c04324d9e7 | |
| author | Ulrich Obergfell <uobergfe@redhat.com> | |
| Fri, 25 Mar 2011 08:45:54 +0000 (25 04:45 -0400) | ||
| committer | Anthony Liguori <aliguori@us.ibm.com> | |
| Fri, 25 Mar 2011 12:28:24 +0000 (25 07:28 -0500) | ||
| tree | a208a61449db46fc5fd08214168c1ad5f3588845 | treesnapshot (tar.gz zip) |
| parent | 05175535a3b6c78186ec3538bcd1b01f30ba571e | commitdiff |
severe memory leak caused by broken palette_destroy() function
The following commit breaks the code of the function palette_destroy().
http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commit;h=e31e3694afef58ba191cbcc6875ec243e5971268
The broken code causes a severe memory leak of 'VncPalette' structures
because it never frees anything:
70 void palette_destroy(VncPalette *palette)
71 {
72 if (palette == NULL) {
73 qemu_free(palette);
74 }
75 }
Version 2 of the patch calls qemu_free() unconditionally.
Signed-off-by: Ulrich Obergfell <uobergfe@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
The following commit breaks the code of the function palette_destroy().
http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commit;h=e31e3694afef58ba191cbcc6875ec243e5971268
The broken code causes a severe memory leak of 'VncPalette' structures
because it never frees anything:
70 void palette_destroy(VncPalette *palette)
71 {
72 if (palette == NULL) {
73 qemu_free(palette);
74 }
75 }
Version 2 of the patch calls qemu_free() unconditionally.
Signed-off-by: Ulrich Obergfell <uobergfe@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| ui/vnc-palette.c | diffblobblamehistory |