| commit | d4e9b75aa03d3f0e08fa431998764d7f72d78a48 | |
| author | Peter Xu <peterx@redhat.com> | |
| Thu, 16 Feb 2017 04:06:01 +0000 (16 12:06 +0800) | ||
| committer | Michael S. Tsirkin <mst@redhat.com> | |
| Fri, 17 Feb 2017 19:52:31 +0000 (17 21:52 +0200) | ||
| tree | 2c583873c25306cdee5871d99683072ddd6164fa | treesnapshot (tar.gz zip) |
| parent | b4b9862b536f41fcdf6ad193a306a852c5b5b71a | commitdiff |
pcie: simplify pcie_add_capability()
When we add PCIe extended capabilities, we should be following the rule
that we add the head extended cap (at offset 0x100) first, then the rest
of them. Meanwhile, we are always adding new capability bits at the end
of the list. Here the "next" looks meaningless in all cases since it
should always be zero (along with the "header").
Simplify the function a bit, and it looks more readable now.
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
When we add PCIe extended capabilities, we should be following the rule
that we add the head extended cap (at offset 0x100) first, then the rest
of them. Meanwhile, we are always adding new capability bits at the end
of the list. Here the "next" looks meaningless in all cases since it
should always be zero (along with the "header").
Simplify the function a bit, and it looks more readable now.
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| hw/pci/pcie.c | diffblobblamehistory |