virtio-bus: Plug devices after features are negotiated
commitd1b4259f1ab18af24e6a297edb6a8f71691f3256
authorMaxime Coquelin <maxime.coquelin@redhat.com>
Tue, 13 Sep 2016 13:30:30 +0000 (13 15:30 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 15 Sep 2016 14:30:03 +0000 (15 17:30 +0300)
treebad5cbf06d5085c33a14b9f4a4f7d654e06772ec
parentd1eb8f2acba579830cf3798c3c15ce51be852c56
virtio-bus: Plug devices after features are negotiated

Currently, devices are plugged before features are negotiated.
If the backend doesn't support VIRTIO_F_VERSION_1, the transport
needs to rewind some settings.

This is the case for CCW, for which a post_plugged callback had
been introduced, where max_rev field is just updated if
VIRTIO_F_VERSION_1 is not supported by the backend.
For PCI, implementing post_plugged would be much more
complicated, so it needs to know whether the backend supports
VIRTIO_F_VERSION_1 at plug time.

Currently, nothing is done for PCI. Modern capabilities get
exposed to the guest even if VIRTIO_F_VERSION_1 is not supported
by the backend, which confuses the guest.

This patch replaces existing post_plugged solution with an
approach that fits with both transports.
Features negotiation is performed before ->device_plugged() call.
A pre_plugged callback is introduced so that the transports can
set their supported features.

Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: qemu-stable@nongnu.org
Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com> [ccw]
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
hw/s390x/virtio-ccw.c
hw/virtio/virtio-bus.c
hw/virtio/virtio-pci.c
hw/virtio/virtio-pci.h
include/hw/virtio/virtio-bus.h