migration: Optimization about wait-unplug migration state
commitd05de9e39a5fb5582a875a95c4b9c2c8584ea694
authorKeqian Zhu <zhukeqian1@huawei.com>
Tue, 4 Feb 2020 05:08:41 +0000 (4 13:08 +0800)
committerJuan Quintela <quintela@redhat.com>
Thu, 13 Feb 2020 09:53:10 +0000 (13 10:53 +0100)
treef18f452e1fa2ce6635b3e86d86a768368db0a23f
parent8958338b10abcb346b54a8038a491fda2db1c853
migration: Optimization about wait-unplug migration state

qemu_savevm_nr_failover_devices() is originally designed to
get the number of failover devices, but it actually returns
the number of "unplug-pending" failover devices now. Moreover,
what drives migration state to wait-unplug should be the number
of "unplug-pending" failover devices, not all failover devices.

We can also notice that qemu_savevm_state_guest_unplug_pending()
and qemu_savevm_nr_failover_devices() is equivalent almost (from
the code view). So the latter is incorrect semantically and
useless, just delete it.

In the qemu_savevm_state_guest_unplug_pending(), once hit a
unplug-pending failover device, then it can return true right
now to save cpu time.

Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Tested-by: Jens Freimann <jfreimann@redhat.com>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/migration.c
migration/savevm.c
migration/savevm.h