nvme: Fix get/set number of queues feature, again
commitcdd346371e09709be8e46398bb097dc690a746f2
authorDan Aloni <dan@kernelim.com>
Sun, 28 May 2017 13:06:49 +0000 (28 16:06 +0300)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 29 Aug 2017 15:54:40 +0000 (29 16:54 +0100)
treeaa68fa10037095d0ba23b0ca1465ed9296e6063b
parent248b23735645f7cbb503d9be6f5bf825f2a603ab
nvme: Fix get/set number of queues feature, again

The number of queues that should be return by the admin command should:

  1) Only mention the number of non-admin queues.
  2) It is zero-based, meaning that '0 == one non-admin queue',
     '1 == two non-admin queues', and so forth.

Because our `num_queues` means the number of queues _plus_ the admin
queue, then the right calculation for the number returned from the admin
command is `num_queues - 2`, combining the two requirements mentioned.

The issue was discovered by reducing num_queues from 64 to 8 and running
a Linux VM with an SMP parameter larger than that (e.g. 22). It tries to
utilize all queues, and therefore fails with an invalid queue number
when trying to queue I/Os on the last queue.

Signed-off-by: Dan Aloni <dan@kernelim.com>
CC: Alex Friedman <alex@e8storage.com>
CC: Keith Busch <keith.busch@intel.com>
CC: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/block/nvme.c