qcow2: Assert that refcount block offsets fit in the refcount table
commitcdc674c7360b59486f5e5aaaa44f7395d2e15888
authorAlberto Garcia <berto@igalia.com>
Wed, 14 Nov 2018 14:58:57 +0000 (14 16:58 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 1 Feb 2019 12:46:44 +0000 (1 13:46 +0100)
tree549b5f636aee9381ca2f98e88368aba7b14dd287
parent67b24427fe581d836946f06c69d68511e1118bd1
qcow2: Assert that refcount block offsets fit in the refcount table

Refcount table entries have a field to store the offset of the
refcount block. The rest of the bits of the entry are currently
reserved.

The offset is always taken from the entry using REFT_OFFSET_MASK to
ensure that we only use the bits that belong to that field.

While that mask is used every time we read from the refcount table, it
is never used when we write to it. Due to the other constraints of the
qcow2 format QEMU can never produce refcount block offsets that don't
fit in that field so any such offset when allocating a refcount block
would indicate a bug in QEMU.

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/qcow2-refcount.c