| commit | cd3ed7db22bafbabcb881f51c168a7cf5aecfa51 | |
| author | Aleksandar Markovic <amarkovic@wavecomp.com> | |
| Mon, 18 Feb 2019 07:32:48 +0000 (18 08:32 +0100) | ||
| committer | Aleksandar Markovic <amarkovic@wavecomp.com> | |
| Thu, 21 Feb 2019 18:36:47 +0000 (21 19:36 +0100) | ||
| tree | 1523dfb79559e0939631a345ad22a6ea374e656d | treesnapshot (tar.gz zip) |
| parent | fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9 | commitdiff |
hw/misc: mips_itu: Fix 32/64 bit issue in a line involving shift operator
Fix 32/64 bit issue in a line involving shift operator. "1 << ..."
calculation of size is done as a 32-bit signed integer which may
then be unintentionally sign-extended into the 64-bit result. The
problem was discovered by Coverity (CID 1398648). Using "1ULL"
instead of "1" on the LHS of the shift fixes this problem.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Fix 32/64 bit issue in a line involving shift operator. "1 << ..."
calculation of size is done as a 32-bit signed integer which may
then be unintentionally sign-extended into the 64-bit result. The
problem was discovered by Coverity (CID 1398648). Using "1ULL"
instead of "1" on the LHS of the shift fixes this problem.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
| hw/misc/mips_itu.c | diffblobblamehistory |