| commit | ca2edcd35cd1a8589dfa0533c19ff232fec7b4b5 | |
| author | Eduardo Habkost <ehabkost@redhat.com> | |
| Thu, 9 Mar 2017 18:50:46 +0000 (9 15:50 -0300) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 14 Mar 2017 12:26:36 +0000 (14 13:26 +0100) | ||
| tree | 1b91cb0f1b4ad83a5e11e7bfbce90d47a0de44e5 | treesnapshot (tar.gz zip) |
| parent | c70b11d160c6bca8e994d40639fcb41558c9fa0a | commitdiff |
kvmclock: Don't crash QEMU if KVM is disabled
Most machines don't allow sysbus devices like "kvmclock" to be
created from the command-line, but some of them do (the ones with
has_dynamic_sysbus=true). In those cases, it's possible to
manually create a kvmclock device without KVM being enabled,
making QEMU crash:
$ qemu-system-x86_64 -machine q35,accel=tcg -device kvmclock
Segmentation fault (core dumped)
This changes kvmclock's realize method to return an error if KVM
is disabled, to ensure it won't crash QEMU.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170309185046.17555-1-ehabkost@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Most machines don't allow sysbus devices like "kvmclock" to be
created from the command-line, but some of them do (the ones with
has_dynamic_sysbus=true). In those cases, it's possible to
manually create a kvmclock device without KVM being enabled,
making QEMU crash:
$ qemu-system-x86_64 -machine q35,accel=tcg -device kvmclock
Segmentation fault (core dumped)
This changes kvmclock's realize method to return an error if KVM
is disabled, to ensure it won't crash QEMU.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170309185046.17555-1-ehabkost@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/i386/kvm/clock.c | diffblobblamehistory |