| commit | c978bd5226f1ed73456ac468a7ed50af3d24dc84 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Fri, 24 Apr 2020 08:43:33 +0000 (24 10:43 +0200) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Thu, 30 Apr 2020 05:26:40 +0000 (30 07:26 +0200) | ||
| tree | 0a375411a70f63073f52ce209d26324511b41896 | treesnapshot (tar.gz zip) |
| parent | faad584adb48737aa3b39984786442a1a9c42aa4 | commitdiff |
qapi: Clean up visitor's recovery from input with invalid type
An alternate type's visit_type_FOO() fails when it runs into an
invalid ->type. If it's an input visit, we then need to free the the
object we got from visit_start_alternate(). We do that with
qapi_free_FOO(), which uses the dealloc visitor.
Trouble is that object is in a bad state: its ->type is invalid. So
the dealloc visitor will run into the same error again, and the error
recovery skips deallocating the alternate's (invalid) alternative.
Works, because qapi_free_FOO() ignores the error.
Avoid it instead: free the messed up object with by g_free().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200424084338.26803-11-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
An alternate type's visit_type_FOO() fails when it runs into an
invalid ->type. If it's an input visit, we then need to free the the
object we got from visit_start_alternate(). We do that with
qapi_free_FOO(), which uses the dealloc visitor.
Trouble is that object is in a bad state: its ->type is invalid. So
the dealloc visitor will run into the same error again, and the error
recovery skips deallocating the alternate's (invalid) alternative.
Works, because qapi_free_FOO() ignores the error.
Avoid it instead: free the messed up object with by g_free().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200424084338.26803-11-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
| scripts/qapi/visit.py | diffblobblamehistory |