| commit | c72fbf98cb243df53b92081dd9daae21c7ea0d46 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Thu, 17 Dec 2015 16:35:16 +0000 (17 17:35 +0100) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Wed, 13 Jan 2016 10:58:58 +0000 (13 11:58 +0100) | ||
| tree | faf8abf945d3f3ffac2a4d37c3254ccb24e929bd | treesnapshot (tar.gz zip) |
| parent | 7b55044f9d96ec518e7ab58bd8a3637b52a35f79 | commitdiff |
sysbus: Don't use hw_error() in machine_init_done_notifiers
platform_bus_map_irq() and platform_bus_map_mmio() use hw_error() to
fail. They run in machine_init_done_notifiers, via
platform_bus_init_notify() and link_sysbus_device(). Printing CPU
registers is not helpful there.
Replace hw_error() by error_report(); exit(1). If these are
programming errors, it should be replaced by an assertion instead.
While there, observe that both functions always return 0, and
link_sysbus_device() ignores the return value. Change them to void.
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1450370121-5768-9-git-send-email-armbru@redhat.com>
platform_bus_map_irq() and platform_bus_map_mmio() use hw_error() to
fail. They run in machine_init_done_notifiers, via
platform_bus_init_notify() and link_sysbus_device(). Printing CPU
registers is not helpful there.
Replace hw_error() by error_report(); exit(1). If these are
programming errors, it should be replaced by an assertion instead.
While there, observe that both functions always return 0, and
link_sysbus_device() ignores the return value. Change them to void.
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1450370121-5768-9-git-send-email-armbru@redhat.com>
| hw/core/platform-bus.c | diffblobblamehistory |