| commit | c6e9d8ae6629aaf3c6d483032d219b988d78583f | |
| author | Max Reitz <mreitz@redhat.com> | |
| Tue, 10 Feb 2015 20:28:45 +0000 (10 15:28 -0500) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Tue, 10 Mar 2015 13:02:21 +0000 (10 14:02 +0100) | ||
| tree | f1cd63950ad12e66a9018465b75f67f5b71b7a28 | treesnapshot (tar.gz zip) |
| parent | 0709c5a1530b046183b6e96d9631affcff76c1fc | commitdiff |
qcow2: Do not return new value after refcount update
qcow2_update_cluster_refcount() does not have any quick access to the
new refcount value, it has to call qcow2_get_refcount(). Some callers do
not need that new value at all, others call qcow2_get_refcount()
themselves anyway (albeit in a different code path, which can however be
easily changed), therefore there is no advantage in making
qcow2_update_cluster_refcount() return the new value. Drop it.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
qcow2_update_cluster_refcount() does not have any quick access to the
new refcount value, it has to call qcow2_get_refcount(). Some callers do
not need that new value at all, others call qcow2_get_refcount()
themselves anyway (albeit in a different code path, which can however be
easily changed), therefore there is no advantage in making
qcow2_update_cluster_refcount() return the new value. Drop it.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| block/qcow2-refcount.c | diffblobblamehistory |