hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev
commitc618e300eb2276996e7004100686768cf1445128
authorDaniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
Wed, 30 Aug 2017 18:21:39 +0000 (30 15:21 -0300)
committerDavid Gibson <david@gibson.dropbear.id.au>
Thu, 7 Sep 2017 23:30:54 +0000 (8 09:30 +1000)
tree7362629ed4161a4d02f7fcab91a0adead12ab408
parentcda4a338c4243fa3bff4498b935340ac7121cc76
hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev

This patch makes a small fix in 'spapr_drc_needed' to change how we detect
if a DRC has a device attached. Previously it used dr_entity_sense for this,
which  works for physical DRCs.

However, for logical DRCs, it didn't cover the case where a logical DRC has
a drc->dev but the state is LOGICAL_UNUSABLE (e.g. a hotplugged CPU before
CAS). In this case, the dr_entity_sense of this DRC returns UNUSABLE and the
code was considering that there were no dev attached, making spapr_drc_needed
return 'false' when in fact we would like to migrate the DRC.

Changing it to check for drc->dev instead works for all DRC types.

Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/ppc/spapr_drc.c