osdep.h: Remove <sys/signal.h> include
commitc0cb758eec848dcbc779bf75a26b49727218e380
authorMichael Forney <mforney@mforney.org>
Wed, 13 Jan 2021 21:56:00 +0000 (13 13:56 -0800)
committerThomas Huth <thuth@redhat.com>
Wed, 20 Jan 2021 09:42:03 +0000 (20 10:42 +0100)
tree4a0e5cee7e1531c936bef4f078aa7bd2571708b2
parent48202c712412c803ddb56365c7bca322aa4e7506
osdep.h: Remove <sys/signal.h> include

Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD
(apart from two .c files). The POSIX standard location for this
header is just <signal.h> and in fact, OpenBSD's signal.h includes
sys/signal.h itself.

Unconditionally including <sys/signal.h> on musl causes warnings
for just about every source file:

  /usr/include/sys/signal.h:1:2: warning: #warning redirecting incorrect #include <sys/signal.h> to <signal.h> [-Wcpp]
      1 | #warning redirecting incorrect #include <sys/signal.h> to <signal.h>
        |  ^~~~~~~

Since there don't seem to be any platforms which require including
<sys/signal.h> in addition to <signal.h>, and some platforms like
Haiku lack it completely, just remove it.

Tested building on OpenBSD after removing this include.

Signed-off-by: Michael Forney <mforney@mforney.org>
Tested-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210113215600.16100-1-mforney@mforney.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
include/qemu/osdep.h
meson.build